On 7/10/2019 9:49 AM, Randy Dunlap wrote: > On 7/10/19 9:38 AM, Casey Schaufler wrote: >> On 7/10/2019 6:34 AM, Aaron Goidel wrote: >>> @@ -3261,6 +3262,26 @@ static int selinux_inode_removexattr(struct dentry *dentry, const char *name) >>> return -EACCES; >>> } >>> >>> +static int selinux_inode_notify(struct inode *inode, u64 mask) >>> +{ >>> + u32 perm = FILE__WATCH; // basic permission, can a watch be set? >> We don't use // comments in the Linux kernel. >> > I thought that we had recently moved into the 21st century on that issue, > but I don't see it mentioned in coding-style.rst. Maybe we need a Doc update. Really? Yuck. Next thing you know M4 macros will be allowed. > > checkpatch allows C99 comments by default. > Joe, do you recall about this? > > thanks.