ack, you going to to merge this? On Mon, Jun 24, 2019 at 2:58 PM Nicolas Iooss <nicolas.iooss@xxxxxxx> wrote: > > In module_to_cil.c, sepol_ppfile_to_module_package() calls functions > from module.c without including the internal header. This makes building > libsepol with "gcc -flto -fuse-ld=gold" fails when linking libsepol.so: > > /tmp/ccHYAKVZ.ltrans21.ltrans.o:<artificial>:function > sepol_ppfile_to_module_package: error: undefined reference to > 'sepol_module_package_free' > /tmp/ccHYAKVZ.ltrans21.ltrans.o:<artificial>:function > sepol_ppfile_to_module_package: error: undefined reference to > 'sepol_module_package_create' > /tmp/ccHYAKVZ.ltrans21.ltrans.o:<artificial>:function > sepol_ppfile_to_module_package: error: undefined reference to > 'sepol_module_package_create' > collect2: error: ld returned 1 exit status > > Fixes: https://github.com/SELinuxProject/selinux/issues/165 > > Signed-off-by: Nicolas Iooss <nicolas.iooss@xxxxxxx> > --- > libsepol/src/module_to_cil.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libsepol/src/module_to_cil.c b/libsepol/src/module_to_cil.c > index da62c8aaf0ef..1af166c9abd0 100644 > --- a/libsepol/src/module_to_cil.c > +++ b/libsepol/src/module_to_cil.c > @@ -54,6 +54,7 @@ > > #include "kernel_to_common.h" > #include "private.h" > +#include "module_internal.h" > > #ifdef __GNUC__ > # define UNUSED(x) UNUSED_ ## x __attribute__((__unused__)) > -- > 2.22.0 >
