merged On Wed, Jun 12, 2019 at 12:57 PM William Roberts <bill.c.roberts@xxxxxxxxx> wrote: > > On Wed, Jun 12, 2019 at 1:44 AM Jan Zarsky <jzarsky@xxxxxxxxxx> wrote: > > > > This series adds new test suites for libsemanage. In the first patch, common > > helper functions are added. The other patches are independent and each adds a > > new test suite. > > > > The test suites are testing only the public API and aim for line coverage. They > > test only correct usage of the functions. Together with valgrind, the test > > suites can be used for detecting memory leaks. > > > > The tests run fine in Travis CI and do not require an SELinux-enabled system. > > > > I welcome any suggestions. > > > > Jan Zarsky (11): > > libsemanage: add helper functions to tests > > libsemanage: test semanage_handle_* functions > > libsemanage: test semanage_bool_* functions > > libsemanage: test semanage_fcontext functions > > libsemanage: test semanage_iface_* functions > > libsemanage: test semanage_ibendport_* functions > > libsemanage: test semanage_node_* functions > > libsemanage: test semanage_port_* functions > > libsemanage: test semanage_user_* functions > > libsemanage: test semanage_context_* functions > > libsemanage: test semanage_msg_default_handler > > > > libsemanage/tests/.gitignore | 1 + > > libsemanage/tests/Makefile | 11 +- > > libsemanage/tests/libsemanage-tests.c | 18 + > > libsemanage/tests/test_bool.c | 932 +++++++++++++++++++++++++++ > > libsemanage/tests/test_bool.cil | 24 + > > libsemanage/tests/test_bool.h | 31 + > > libsemanage/tests/test_fcontext.c | 1045 +++++++++++++++++++++++++++++++ > > libsemanage/tests/test_fcontext.cil | 25 + > > libsemanage/tests/test_fcontext.h | 30 + > > libsemanage/tests/test_handle.c | 329 ++++++++++ > > libsemanage/tests/test_handle.cil | 21 + > > libsemanage/tests/test_handle.h | 30 + > > libsemanage/tests/test_ibendport.c | 525 ++++++++++++++++ > > libsemanage/tests/test_ibendport.cil | 28 + > > libsemanage/tests/test_ibendport.h | 30 + > > libsemanage/tests/test_iface.c | 666 ++++++++++++++++++++ > > libsemanage/tests/test_iface.cil | 28 + > > libsemanage/tests/test_iface.h | 30 + > > libsemanage/tests/test_node.c | 807 ++++++++++++++++++++++++ > > libsemanage/tests/test_node.cil | 28 + > > libsemanage/tests/test_node.h | 30 + > > libsemanage/tests/test_other.c | 120 ++++ > > libsemanage/tests/test_other.h | 30 + > > libsemanage/tests/test_port.c | 909 +++++++++++++++++++++++++++ > > libsemanage/tests/test_port.cil | 27 + > > libsemanage/tests/test_port.h | 30 + > > libsemanage/tests/test_semanage_store.c | 2 +- > > libsemanage/tests/test_user.c | 690 ++++++++++++++++++++ > > libsemanage/tests/test_user.cil | 27 + > > libsemanage/tests/test_user.h | 30 + > > libsemanage/tests/utilities.c | 254 +++++++- > > libsemanage/tests/utilities.h | 53 +- > > 32 files changed, 6831 insertions(+), 10 deletions(-) > > > > > Ack > Staged: https://github.com/SELinuxProject/selinux/pull/159