Re: [PATCH] trivial: remove unneeded int

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jokke Hämäläinen <jokke.hamalainen@xxxxxxxxxxxx> writes:

> diff --git a/libsepol/src/context.c b/libsepol/src/context.c
> index a88937fc..e81b28c6 100644
> --- a/libsepol/src/context.c
> +++ b/libsepol/src/context.c
> @@ -38,7 +38,6 @@ int context_is_valid(const policydb_t * p, const context_struct_t * c)
>  	role_datum_t *role;
>  	user_datum_t *usrdatum;
>  	ebitmap_t types, roles;
> -	int ret = 1;
>  
>  	ebitmap_init(&types);
>  	ebitmap_init(&roles);
> @@ -75,7 +74,7 @@ int context_is_valid(const policydb_t * p, const context_struct_t * c)
>  	if (!mls_context_isvalid(p, c))
>  		return 0;
>  
> -	return ret;
> +	return 1;
>  }
>  
>  /*

ack

Would you please add Signed-off line (git commit -s ...) to the description, see
`git log` and https://developercertificate.org/

Also, if the patch applies only to one subdirectory it's a common practice
to use prefix in the subject of the patch, e.g.:

libsepol: trivial: remove unneeded int

Petr



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux