On Thu, May 30, 2019 at 12:22:15PM +0300, Sergei Shtylyov wrote: > On 30.05.2019 12:18, Gen Zhang wrote: > > >>On 30.05.2019 11:06, Gen Zhang wrote: > >> > >>>In selinux_add_mnt_opt(), 'val' is allcoted by kmemdup_nul(). It returns > >> > >> Allocated? > > >Thanks for your reply, Sergei. I used 'allocated' because kmemdup_nul() > >does some allocation in its implementation. And its docs descrips: > > Describes? > > >"Return: newly allocated copy of @s with NUL-termination or %NULL in > >case of error". I think it is proper to use 'allocated' here. But it > >could be 'assigned', which is better, right? > > I was only trying to point out the typos in this word. :-) > > >Thanks > >Gen > >> > >>>NULL when fails. So 'val' should be checked. > >>> > >>>Signed-off-by: Gen Zhang <blackgod016574@xxxxxxxxx> > >>[...] > > MBR, Sergei Well, my mistake. Thanks for your comments, Sergei! Thanks Gen
