On Wed, Feb 27, 2019 at 12:46 PM Paulo Alcantara <paulo@xxxxxxxx> wrote: > Paul Moore <paul@xxxxxxxxxxxxxx> writes: > > > On Wed, Feb 27, 2019 at 12:07 PM Paulo Alcantara <paulo@xxxxxxxx> wrote: > >> Paulo Alcantara <paulo@xxxxxxxx> writes: > >> > When compiling genheaders and mdp from a newer host kernel, the > >> > following error happens: > >> > > >> > In file included from scripts/selinux/genheaders/genheaders.c:18: > >> > ./security/selinux/include/classmap.h:238:2: error: #error New > >> > address family defined, please update secclass_map. #error New > >> > address family defined, please update secclass_map. ^~~~~ > >> > make[3]: *** [scripts/Makefile.host:107: > >> > scripts/selinux/genheaders/genheaders] Error 1 make[2]: *** > >> > [scripts/Makefile.build:599: scripts/selinux/genheaders] Error 2 > >> > make[1]: *** [scripts/Makefile.build:599: scripts/selinux] Error 2 > >> > make[1]: *** Waiting for unfinished jobs.... > >> > > >> > Instead of relying on the host definition, include linux/socket.h in > >> > classmap.h to have PF_MAX. > >> > > >> > Signed-off-by: Paulo Alcantara <paulo@xxxxxxxx> > >> > --- > >> > scripts/selinux/genheaders/genheaders.c | 1 - > >> > scripts/selinux/mdp/mdp.c | 1 - > >> > security/selinux/include/classmap.h | 1 + > >> > 3 files changed, 1 insertion(+), 2 deletions(-) > >> > >> Ping? > >> > >> Could someone please take a look at this issue? > > > > It looks fine to me, but I typically don't merge patches this late in > > the development window (we are at -rc8), unless it is a serious bug > > fix. > > Fair enough. > > >> It's quite easy to reproduce on my host (4.20+) when building an > >> unpatched 4.14 kernel ... > > > > While this is a good patch that does fix a real but, the fact that it > > has been broken for several releases tells me this is not a serious > > bug and not likely worth the risk for the upcoming merge window > > (however small it may be). There has been a lot of good work put into > > mdp very recently, and I expect to merge that, as well as your fix, > > once the upcoming merge window closes. > > Looks good to me. Thanks! Merged into selinux/next, thanks for the patch and your patience. -- paul moore www.paul-moore.com
