On 2/5/19 11:17 PM, William A. Kennington III wrote:
Entries in the secclass_map are expexted to be null terminated. The BPF
entry was added without the NULL terminating and incosistent formatting.
This patch cleans that up.
Thanks. A few minor nits:
A couple of spelling errors above (expected, inconsistent). Also, per
Documentation/process/submitting-patches.rst, rather than say "This
patch cleans that up", say "Clean that up" or similar.
Can add a:
Fixes: ec27c3568a34c7f ("selinux: bpf: Add selinux check for eBPF
syscall operations")
Signed-off-by: William A. Kennington III <william@xxxxxxxxxxxxxxx>
---
security/selinux/include/classmap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/selinux/include/classmap.h b/security/selinux/include/classmap.h
index bd5fe0d3204a..7ff68a5e4c58 100644
--- a/security/selinux/include/classmap.h
+++ b/security/selinux/include/classmap.h
@@ -239,7 +239,7 @@ struct security_class_mapping secclass_map[] = {
{ "infiniband_endport",
{ "manage_subnet", NULL } },
{ "bpf",
- {"map_create", "map_read", "map_write", "prog_load", "prog_run"} },
+ { "map_create", "map_read", "map_write", "prog_load", "prog_run", NULL } },
Should likely break the line to make checkpatch.pl happy:
$ ./scripts/checkpatch.pl -g HEAD
WARNING: line over 80 characters
#24: FILE: security/selinux/include/classmap.h:242:
+ { "map_create", "map_read", "map_write", "prog_load", "prog_run",
NULL } },
{ "xdp_socket",
{ COMMON_SOCK_PERMS, NULL } },
{ NULL }
