Based on idea from Nicolas Iooss <nicolas.iooss@xxxxxxx> Fixes: $ sudo semanage Traceback (most recent call last): File "/usr/sbin/semanage", line 28, in <module> import seobject File "/usr/lib/python3.7/site-packages/seobject.py", line 1045, in <module> class portRecords(semanageRecords): File "/usr/lib/python3.7/site-packages/seobject.py", line 1047, in portRecords valid_types = list(list(sepolicy.info(sepolicy.ATTRIBUTE, "port_type"))[0]["types"]) File "/usr/lib/python3.7/site-packages/sepolicy/__init__.py", line 203, in <genexpr> return ({ File "/usr/lib64/python3.7/site-packages/setools/typeattrquery.py", line 65, in results for attr in self.policy.typeattributes(): AttributeError: 'NoneType' object has no attribute 'typeattributes' https://github.com/SELinuxProject/selinux/issues/81 Signed-off-by: Petr Lautrbach <plautrba@xxxxxxxxxx> --- python/semanage/seobject.py | 57 ++++++++++++++++++++++--------------- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git a/python/semanage/seobject.py b/python/semanage/seobject.py index efec0a55..4490e03f 100644 --- a/python/semanage/seobject.py +++ b/python/semanage/seobject.py @@ -1043,13 +1043,15 @@ class seluserRecords(semanageRecords): class portRecords(semanageRecords): - try: - valid_types = list(list(sepolicy.info(sepolicy.ATTRIBUTE, "port_type"))[0]["types"]) - except RuntimeError: - valid_types = [] + + valid_types = [] def __init__(self, args = None): semanageRecords.__init__(self, args) + try: + self.valid_types = list(list(sepolicy.info(sepolicy.ATTRIBUTE, "port_type"))[0]["types"]) + except RuntimeError: + pass def __genkey(self, port, proto): if proto == "tcp": @@ -1321,14 +1323,16 @@ class portRecords(semanageRecords): print(rec) class ibpkeyRecords(semanageRecords): - try: - q = setools.TypeQuery(setools.SELinuxPolicy(sepolicy.get_installed_policy()), attrs=["ibpkey_type"]) - valid_types = sorted(str(t) for t in q.results()) - except: - valid_types = [] + + valid_types = [] def __init__(self, args = None): semanageRecords.__init__(self, args) + try: + q = setools.TypeQuery(setools.SELinuxPolicy(sepolicy.get_installed_policy()), attrs=["ibpkey_type"]) + self.valid_types = sorted(str(t) for t in q.results()) + except: + pass def __genkey(self, pkey, subnet_prefix): if subnet_prefix == "": @@ -1579,14 +1583,16 @@ class ibpkeyRecords(semanageRecords): print(rec) class ibendportRecords(semanageRecords): - try: - q = setools.TypeQuery(setools.SELinuxPolicy(sepolicy.get_installed_policy()), attrs=["ibendport_type"]) - valid_types = set(str(t) for t in q.results()) - except: - valid_types = [] + + valid_types = [] def __init__(self, args = None): semanageRecords.__init__(self, args) + try: + q = setools.TypeQuery(setools.SELinuxPolicy(sepolicy.get_installed_policy()), attrs=["ibendport_type"]) + self.valid_types = set(str(t) for t in q.results()) + except: + pass def __genkey(self, ibendport, ibdev_name): if ibdev_name == "": @@ -1823,14 +1829,16 @@ class ibendportRecords(semanageRecords): print(rec) class nodeRecords(semanageRecords): - try: - valid_types = list(list(sepolicy.info(sepolicy.ATTRIBUTE, "node_type"))[0]["types"]) - except RuntimeError: - valid_types = [] + + valid_types = [] def __init__(self, args = None): semanageRecords.__init__(self, args) self.protocol = ["ipv4", "ipv6"] + try: + self.valid_types = list(list(sepolicy.info(sepolicy.ATTRIBUTE, "node_type"))[0]["types"]) + except RuntimeError: + pass def validate(self, addr, mask, protocol): newaddr = addr @@ -2264,14 +2272,17 @@ class interfaceRecords(semanageRecords): class fcontextRecords(semanageRecords): - try: - valid_types = list(list(sepolicy.info(sepolicy.ATTRIBUTE, "file_type"))[0]["types"]) - valid_types += list(list(sepolicy.info(sepolicy.ATTRIBUTE, "device_node"))[0]["types"]) - except RuntimeError: - valid_types = [] + + valid_types = [] def __init__(self, args = None): semanageRecords.__init__(self, args) + try: + self.valid_types = list(list(sepolicy.info(sepolicy.ATTRIBUTE, "file_type"))[0]["types"]) + self.valid_types += list(list(sepolicy.info(sepolicy.ATTRIBUTE, "device_node"))[0]["types"]) + except RuntimeError: + pass + self.equiv = {} self.equiv_dist = {} self.equal_ind = False -- 2.20.1