Hello, On Thu, Dec 13, 2018 at 03:17:37PM +0100, Ondrej Mosnacek wrote: > This fixes the case where all mount options specified are consumed by an > LSM and all that's left is an empty string. In this case cgroupfs should > accept the string and not fail. > > How to reproduce (with SELinux enabled): > > # umount /sys/fs/cgroup/unified > # mount -o context=system_u:object_r:cgroup_t:s0 -t cgroup2 cgroup2 /sys/fs/cgroup/unified > mount: /sys/fs/cgroup/unified: wrong fs type, bad option, bad superblock on cgroup2, missing codepage or helper program, or other error. > # dmesg | tail -n 1 > [ 31.575952] cgroup: cgroup2: unknown option "" > > Fixes: 67e9c74b8a87 ("cgroup: replace __DEVEL__sane_behavior with cgroup2 fs type") > [NOTE: should apply on top of commit 5136f6365ce3 ("cgroup: implement "nsdelegate" mount option"), older versions need manual rebase] > Suggested-by: Stephen Smalley <sds@xxxxxxxxxxxxx> > Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx> Applied to cgroup/for-4.21. Thanks. -- tejun