On Mon, Jul 2, 2018 at 10:10 PM Joe Perches <joe@xxxxxxxxxxx> wrote: > On Mon, 2018-07-02 at 21:15 -0400, Paul Moore wrote: > > On Mon, Jul 2, 2018 at 5:31 PM Joe Perches <joe@xxxxxxxxxxx> wrote: > > > On Mon, 2018-07-02 at 16:51 -0400, Paul Moore wrote: > > > > On Wed, Jun 20, 2018 at 2:39 AM Joe Perches <joe@xxxxxxxxxxx> wrote: > > > > > pr_fmt can be used with the pr_<level> macros to prefix > > > > > arbitrary content to logging messages. > > > > > > > > > > So add '#define pr_fmt(fmt) "SELinux: " fmt' to selinux files > > > > > that use pr_<level> and remove embedded "SELinux: " prefixes > > > > > from the format strings. > > > [] > > > > What tree did you base your patch on? > > > > > > next-20180619 on the day it was sent. > > > > > > > Please base SELinux patches > > > > either on the SELinux tree or Linus' tree. The SELinux tree can be > > > > found at the links below: > > > > > > > > * git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git > > > > * https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git > > > > > > It's almost always better to use selinux/next. > > > Why should this patch be different? > > > > Yes, that's what I said, please base your patch against the selinux/next branch. > > Again, this patch was based on that branch on the date the > patch was sent. > > It still applies today to -next. It doesn't apply cleanly to the selinux/next branch, I believe because there are other trees which have made changes under security/selinux/* (I believe there was some fs related work from David Howells that touched some SELinux/LSM code). As I said earlier, if you want me to apply your patches to the SELinux tree, please base them either against the selinux/next tree or against Linus' tree. -- paul moore www.paul-moore.com _______________________________________________ Selinux mailing list Selinux@xxxxxxxxxxxxx To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx. To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.