On Mon, May 21, 2018 at 10:42:15PM +0200, Nicolas Iooss wrote: > On Mon, May 21, 2018 at 12:03 PM, Jason Zaman <jason@xxxxxxxxxxxxx> wrote: > > > > Ruby 2.5 is not installed by default, force reinstall with rvm > > > > Signed-off-by: Jason Zaman <jason@xxxxxxxxxxxxx> > > --- > > > > This passes on my repo: > > https://travis-ci.org/perfinion/selinux/builds/381597252 > > This passes on my repo too, both without any modifications compared to > upstream and with some modifications to Makefiles (I enabled more > warning flags in my repo, like clang -Weverything, but they trigger > some false positive depending on the compiler version, which is why I > do not upstream these modifications). For the record, clang did not > like the "__error__" attribute used by some Ruby headers (cf. > https://travis-ci.org/fishilico/selinux/builds/381760812) and this is > not an issue related to the project. Thats awesome! I was looking through your branch, you have a few things marked as not upstreamable (like the flake8 py linter) and a few asserts to silence the static analyzer. I don't see why those couldnt be upstreamed. we have the scripts/ dir with a couple things already, I would support putting more in there then you wouldnt have to maintain it on your own and keep rebasing and whatnot. And maybe the static analyzer isnt quite ready to upstream so fast, but I dont see problems with the fixes. eg this kind of stuff seems good: https://github.com/fishilico/selinux/commit/46b056fdbc90fcf8a22c77bc17b4a4ee77ee28eb > Acked-by: Nicolas Iooss <nicolas.iooss@xxxxxxx> Cool, i'll push it tmrr then :) -- Jason _______________________________________________ Selinux mailing list Selinux@xxxxxxxxxxxxx To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx. To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.
