On Fri, May 04, 2018 at 01:58:08PM -0400, Stephen Smalley wrote: > On 05/04/2018 07:51 AM, Petr Lautrbach wrote: > > From: Vit Mojzis <vmojzis@xxxxxxxxxx> > > > > self.store is always a string (actual store name or "") because of > > semanageRecords.__init__. Fix check for not defined store. > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1559174#c3 > > > > Signed-off-by: Vit Mojzis <vmojzis@xxxxxxxxxx> > > --- > > python/semanage/seobject.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/python/semanage/seobject.py b/python/semanage/seobject.py > > index ac310ea6..c76dce85 100644 > > --- a/python/semanage/seobject.py > > +++ b/python/semanage/seobject.py > > @@ -2651,7 +2651,7 @@ class booleanRecords(semanageRecords): > > self.current_booleans = [] > > ptype = None > > > > - if self.store is None or self.store == ptype: > > + if self.store == "" or self.store == ptype: > > self.modify_local = True > > else: > > self.modify_local = False > > > > Is there a reason you didn't use if not self.store here? > There's a similar check on line 258 and this just follows the same pattern.
Attachment:
signature.asc
Description: PGP signature
