On Sat, Apr 14, 2018 at 2:40 AM, William Roberts <bill.c.roberts@xxxxxxxxx> wrote: > In general this series looks fine. > > However, checkpatch.pl is complaining about DOS line endings in your patches: > > For example: > ERROR: DOS line endings > #325: FILE: libselinux/src/label_file.h:281: > +^I^Iint alloc_stems = data->alloc_stems * 2 + 16;^M$ This is unexpected. On my computer, "file" gives the following output on the .patch files (there is no "..., with CRLF line terminators"): 0001-libsepol-do-not-dereference-NULL-if-stack_init-fails.patch: unified diff output, ASCII text 0002-libsepol-ensure-the-level-context-is-not-empty.patch: unified diff output, ASCII text 0003-libselinux-label_file-fix-memory-management-in-store.patch: unified diff output, ASCII text 0004-libselinux-fix-memory-leak-in-getconlist.patch: unified diff output, ASCII text 0005-libselinux-remove-unused-variable-usercon.patch: unified diff output, ASCII text Nevertheless, my messages seem to use CR+LF line endings. I am wondering whether this is a new feature of "git send-email" or of my SMTP server mangling text emails... Anyway, "git am *.patch && git format-patch origin/master" produces files with LF line endings, so git seems to handle fine this kind of modification. By the way, I have also pushed these patches on my Github repository, https://github.com/fishilico/selinux/commits/92717db1cb9dd6c8faf8fae3325f6a9d4c1002ca . Thanks! Nicolas
