On April 7, 2018 1:03:57 PM Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: On Sat, Apr 7, 2018 at 9:54 AM, Richard Haines <richard_c_haines@xxxxxxxxxxxxxx> wrote: So please check my resolution, but also somebody should tell me "Linus, you're a cretin, sctp_connect() doesn't want that security_sctp_bind_connect() at all because it was already done by XYZ" sctp_connect() or __sctp_connect() do not need to call security_sctp_bind_connect(). This is because the connect(2) call will handle the checks required via security_socket_connect(): Ok, thanks, that's exactly what I wanted to get. Anyway, somebody should still verify that it all looks good in my tree, but I don't actually expect the merge to have had any issues even if the refactoring made it a bit more complex than most merges are. Thanks for the quick response Richard. Xin Long looked it over and gave it the thumbs up, I'll take a look too, but to be honest I trust his SCTP understanding much more than mine. I also do weekly tests of each rcX release at a minimum so if something odd pops up I'll make sure you get a fix. Thanks again everyone. -- paul moore www.paul-moore.com
