On Wed, Mar 14, 2018 at 8:30 PM, Petr Lautrbach <plautrba@xxxxxxxxxx> wrote: > > On Sun, Mar 11, 2018 at 11:15:27PM +0100, Nicolas Iooss wrote: > > libselinux and libsemanage Makefiles invoke site.getsitepackages() in > > order to get the path to the directory /usr/lib/pythonX.Y/site-packages > > that matches the Python interpreter chosen with $(PYTHON). This method > > is incompatible with Python virtual environments, as described in > > https://github.com/pypa/virtualenv/issues/355#issuecomment-10250452 . > > This issue has been opened for more than 5 years. > > > > On the contrary python/semanage/ and python/sepolgen/ Makefiles use > > distutils.sysconfig.get_python_lib() in order to get the site-packages > > path into a variable named PYTHONLIBDIR. This way of computing > > PYTHONLIBDIR is compatible with virtual environments and gives the same > > result as PYSITEDIR. > > > > As PYTHONLIBDIR works in more cases than PYSITEDIR, make libselinux and > > libsemanage Makefiles use it. And as native code is installed (as part > > of the SWIG wrapper), use "plat_specific=1" in order to use /usr/lib64 > > on systems which distinguish /usr/lib64 from /usr/lib. > > > > Signed-off-by: Nicolas Iooss <nicolas.iooss@xxxxxxx> > > Looks good to me. Thanks! > > https://github.com/SELinuxProject/selinux/pull/86 > > Acked-by: Petr Lautrbach <plautrba@xxxxxxxxxx> Thanks. I have merged the patch. Nicolas
