On Thu, Feb 22, 2018 at 5:59 PM, Petr Lautrbach <plautrba@xxxxxxxxxx> wrote:
> On Thu, Feb 22, 2018 at 04:31:46PM +0100, Petr Lautrbach wrote:
>> On Sun, Feb 18, 2018 at 07:20:02PM +0100, Nicolas Iooss wrote:
>> > On Sun, Feb 18, 2018 at 7:09 PM, Nicolas Iooss <nicolas.iooss@xxxxxxx> wrote:
>> > > On Wed, Feb 14, 2018 at 10:53 AM, Petr Lautrbach <plautrba@xxxxxxxxxx> wrote:
>> > >> Hi,
>> > >>
>> > >> The following set of patches update polgengui.py, rename polgen.glade to
>> > >> polgen.ui, convert it to new format, and fix some other sepolicy Python 3
>> > >> related issues.
>> > >
>> > > Hi,
>> > > I have read and tested these patches and they look good to me.
>> > (Oops, the mail has been sent before I finished writing it...)
>> >
>> > In order to run polgengui on my development system which uses a policy
>> > without MLS, I needed a patch in sepolicy, that I sent a few days ago
>> > ("[PATCH 1/3] python/sepolicy: Support non-MLS policy"). With this I
>> > have been able to play with polgengui and have been surprised by a
>> > warning which appears on my terminal every time I type anything in the
>> > "name" field of the form in the second tab ("Enter name of application
>> > or user role:"):
>> >
>> > polgengui.py:778: Warning: g_value_get_int: assertion
>> > 'G_VALUE_HOLDS_INT (value)' failed
>> > Gtk.main()
>> >
>> > Have you got such warning on your system? Do you know where this
>> > warning comes from? For information I use Gtk3 3.22.26 with
>> > python-gobject 3.26.1.
>>
>>
>> I see it as well. I'll try to find the problem and sent a patch for that.
>
> It's caused by line 624 in polgengui.py
>
> 624 self.name_entry.connect("insert_text", self.on_name_entry_changed)
>
> According to [2][3] it's long term known problem. There's a suggested fix in [1]
> but I don't know how to apply it at this moment.
>
> Given that it's not fatal and doesn't have a real impact on the code - you can't
> insert " " into Name value, I'd leave as it is for now.
>
> [1] https://stackoverflow.com/questions/38815694/gtk-3-position-attribute-on-insert-text-signal-from-gtk-entry-is-always-0
> [2] https://bugzilla.gnome.org/show_bug.cgi?id=644927
> [3] https://gitlab.gnome.org/GNOME/pygobject/issues/12
>
>
> There's another deprecation warning:
>
> /usr/share/system-config-selinux/polgengui.py:679: PyGIDeprecationWarning: Deprecated, please use stop_emission_by_name.
> entry.emit_stop_by_name("insert_text")
>
> which seems to be easy to fix
>
> --- a/gui/polgengui.py
> +++ b/gui/polgengui.py
> @@ -674,7 +674,7 @@ class childWindow:
>
> def on_name_entry_changed(self, entry, text, size, position):
> if text.find(" ") >= 0:
> - entry.emit_stop_by_name("insert_text")
> + entry.stop_emission_by_name("insert-text")
>
> def on_focus_out_event(self, entry, third):
> name = entry.get_text()
>
>
> I'll send a patch for that.
Excellent! Unfortunately I will be travelling the next ten days and I
will not be able to review or test your patches before my return. The
review can of course be done by another maintainer, so there is no
issue.
Thanks,
Nicolas
