Re: [PATCH] python/semanage: Remove redundant and broken moduleRecords.modify()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-01-11 at 18:44 +0100, Vit Mojzis wrote:
> moduleRecords.modify() calls nonexistent function
> semanage_module_update_file (maybe it should have been
> semanage_module_upgrade_file which is now obsolete and calls
> semanage_module_install_file) and the job of updating a module is
> done
> by moduleRecords.add().
> 
> Signed-off-by: Vit Mojzis <vmojzis@xxxxxxxxxx>

Thanks, applied.

> ---
>  python/semanage/seobject.py | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/python/semanage/seobject.py
> b/python/semanage/seobject.py
> index b927b18..740bd7c 100644
> --- a/python/semanage/seobject.py
> +++ b/python/semanage/seobject.py
> @@ -423,11 +423,6 @@ class moduleRecords(semanageRecords):
>                      raise ValueError(_("Could not disable module
> %s") % m)
>          self.commit()
>  
> -    def modify(self, file):
> -        rc = semanage_module_update_file(self.sh, file)
> -        if rc >= 0:
> -            self.commit()
> -
>      def delete(self, module, priority):
>          rc = semanage_set_default_priority(self.sh, priority)
>          if rc < 0:



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux