Hi, On Sun, Jan 07, 2018 at 09:38:58PM +0100, Nicolas Iooss wrote: > On Wed, Jan 3, 2018 at 10:13 PM, Marcus Folkesson > <marcus.folkesson@xxxxxxxxx> wrote: > > `prefix` in the .pc file may be messed up when using a buildsystem > > that has specified a sysroot as DESTDIR. > > We need to make it possible to override the default `libdir` > > and `includedir`. > > > > `includedir` may be overridden by `INCLUDEDIR` but `libdir` is using > > `PREFIX` to setup the path. > > > > Therefore, introduce PCPREFIX to make it possible to generate a more > > customized .pc file. > > > > Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx> > > Looks good to me. This patch does not seem to break the existing usage > and adds more flexibility for packagers. By the way, I was worried by > the modification on INCLUDEDIR, but as this variable is only used to > generate pkg-config files, it is reasonable to use PCPREFIX instead of > PREFIX in its definition. > > Acked-by: Nicolas Iooss <nicolas.iooss@xxxxxxx> Thank you for your review Nicolas. I'm currently reworking the Makefiles again. After more digging I have came to the conclusion that the main problem is that the Makefiles does not follow the standard semantic of DESTDIR and PREFIX. I will try to fix this. I suggest that we drop this patch and wait for my new patchsets. Thank you Best regards Marcus Folkesson
