On 10/7/2017 7:02 AM, Thomas Meyer wrote:
> Bool initializations should use true and false. Bool tests don't need
> comparisons.
>
> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
> ---
>
> diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
> --- a/security/selinux/ss/mls.c
> +++ b/security/selinux/ss/mls.c
> @@ -550,7 +550,7 @@ int mls_compute_sid(struct context *scon
>
> /* Fallthrough */
> case AVTAB_CHANGE:
> - if ((tclass == policydb.process_class) || (sock == true))
> + if ((tclass == policydb.process_class) || (sock))
bool tests don't need parentheses, either.
+ if ((tclass == policydb.process_class) || sock)
> /* Use the process MLS attributes. */
> return mls_context_cpy(newcontext, scontext);
> else
> diff -u -p a/security/selinux/ss/services.c b/security/selinux/ss/services.c
> --- a/security/selinux/ss/services.c
> +++ b/security/selinux/ss/services.c
> @@ -1656,7 +1656,7 @@ static int security_compute_sid(u32 ssid
> } else if (cladatum && cladatum->default_role == DEFAULT_TARGET) {
> newcontext.role = tcontext->role;
> } else {
> - if ((tclass == policydb.process_class) || (sock == true))
> + if ((tclass == policydb.process_class) || (sock))
Likewise
> newcontext.role = scontext->role;
> else
> newcontext.role = OBJECT_R_VAL;
> @@ -1668,7 +1668,7 @@ static int security_compute_sid(u32 ssid
> } else if (cladatum && cladatum->default_type == DEFAULT_TARGET) {
> newcontext.type = tcontext->type;
> } else {
> - if ((tclass == policydb.process_class) || (sock == true)) {
> + if ((tclass == policydb.process_class) || (sock)) {
On more time.
> /* Use the type of process. */
> newcontext.type = scontext->type;
> } else {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
