Re: [pcmoore-selinux:next 17/17] security/selinux/ibpkey.c:116:24: sparse: incompatible types in comparison expression (different address spaces)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 21, 2017 at 5:47 AM, kbuild test robot
<fengguang.wu@xxxxxxxxx> wrote:
> tree:   git://git.infradead.org/users/pcmoore/selinux next
> head:   b76dd295790d44ecb04932110309bb6c15f263a8
> commit: b76dd295790d44ecb04932110309bb6c15f263a8 [17/17] selinux: Add a cache for quicker retreival of PKey SIDs
> reproduce:
>         # apt-get install sparse
>         git checkout b76dd295790d44ecb04932110309bb6c15f263a8
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>    include/linux/compiler.h:264:8: sparse: attribute 'no_sanitize_address': unknown attribute
>>> security/selinux/ibpkey.c:116:24: sparse: incompatible types in comparison expression (different address spaces)

I haven't looked at this too closely, but this may not be significant
... Daniel, can you look into this please?

> vim +116 security/selinux/ibpkey.c
>
>    100   * Description:
>    101   * Add a new pkey record to the hash table.
>    102   *
>    103   */
>    104  static void sel_ib_pkey_insert(struct sel_ib_pkey *pkey)
>    105  {
>    106          unsigned int idx;
>    107
>    108          /* we need to impose a limit on the growth of the hash table so check
>    109           * this bucket to make sure it is within the specified bounds
>    110           */
>    111          idx = sel_ib_pkey_hashfn(pkey->psec.pkey);
>    112          list_add_rcu(&pkey->list, &sel_ib_pkey_hash[idx].list);
>    113          if (sel_ib_pkey_hash[idx].size == SEL_PKEY_HASH_BKT_LIMIT) {
>    114                  struct sel_ib_pkey *tail;
>    115
>  > 116                  tail = list_entry(
>    117                          rcu_dereference_protected(
>    118                                  sel_ib_pkey_hash[idx].list.prev,
>    119                                  lockdep_is_held(&sel_ib_pkey_lock)),
>    120                          struct sel_ib_pkey, list);
>    121                  list_del_rcu(&tail->list);
>    122                  kfree_rcu(tail, rcu);
>    123          } else {
>    124                  sel_ib_pkey_hash[idx].size++;
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

-- 
paul moore
www.paul-moore.com



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux