Re: [PATCH v7 2/9] IB/core: Enforce PKey security on QPs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 19 May 2017, Dan Jurgens wrote:

> security/security.c                  | 385 ++++++++++++++++++++++

This looks wrong -- merge problem?


> +	if (pps->alt.state != IB_PORT_PKEY_NOT_VALID) {
> +		get_pkey_and_subnet_prefix(&pps->alt,
> +					   &pkey,
> +					   &subnet_prefix);
> +
> +		ret = enforce_qp_pkey_security(pkey,
> +					       subnet_prefix,
> +					       sec);
> +	}
> +
> +	if (ret)
> +		goto out;

The above if/goto is unnecessary.

> +
> +out:
> +	return ret;
> +}



-- 
James Morris
<jmorris@xxxxxxxxx>




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux