On 5/10/2017 1:56 PM, Stephen Smalley wrote: > On Tue, 2017-05-09 at 23:50 +0300, Dan Jurgens wrote: >> From: Daniel Jurgens <danielj@xxxxxxxxxxxx> >> } ibendport; > These were pkey and ib_endport in the kernel patch, and port was > port_num. Either way is fine but they probably ought to be consistent. Yes, I received an internal comment that pkey wouldn't be an especially strange name collision in the future. When I repost the kernel series I'll synchronize the names there for consistency. >> @@ -396,6 +400,7 @@ typedef struct genfs { >> #define OCON_FSUSE 5 /* fs_use */ >> #define OCON_NODE6 6 /* IPv6 nodes */ >> #define OCON_IBPKEY 7 /* Infiniband PKEY */ >> +#define OCON_IBENDPORT 8 /* Infiniband End Port */ > These were OCON_PKEY and OCON_IB_ENDPORT in the last kernel patches I > saw. Ok either way but they probably ought to be consistent. Same here.