I've been reworking some bits of ostree/rpm-ostree's SELinux support recently in https://github.com/ostreedev/ostree/pull/797 - basically using setfscreatecon() more. However, I ran into an interesting thing I think is a bug - if others agree I can write a patch. Right now, as far as I can see, after a process calls selinux_set_policy_root(), every further call to is_selinux_enabled() will return FALSE (0). In current git master of libselinux, we initialize via a library constructor: https://github.com/SELinuxProject/selinux/blob/89ce96cac6ce5eeed78cb39c58514cd68494d7aa/libselinux/src/init.c#L151 Now, selinux_set_policy_root() explicitly undoes this initialization: https://github.com/SELinuxProject/selinux/blob/89ce96cac6ce5eeed78cb39c58514cd68494d7aa/libselinux/src/selinux_config.c#L285 Why does it do that? It looks like this call existed since the function was created in https://github.com/SELinuxProject/selinux/commit/7fe6036ca5e3624d6e3a0294b909d93b145eac31 And I can't see any other place where we will reinitialize the variable; There's no API to reinitialize `selinux_mnt`, it's only set once at library init time. In other words... diff --git a/libselinux/src/selinux_config.c b/libselinux/src/selinux_config.c index d8e140c..292728f 100644 --- a/libselinux/src/selinux_config.c +++ b/libselinux/src/selinux_config.c @@ -282,7 +282,6 @@ int selinux_set_policy_root(const char *path) } policy_type++; - fini_selinuxmnt(); fini_selinux_policyroot(); selinux_policyroot = strdup(path); Right?
