On 04/11/2017 04:31 PM, Nicolas Iooss wrote:
On Tue, Apr 11, 2017 at 7:53 PM, James Carter <jwcart2@xxxxxxxxxxxxx
<mailto:jwcart2@xxxxxxxxxxxxx>> wrote:
Added "-G, --expand_generated" option to specify that all automatically
generated attributes should be expanded and removed.
Added "-X, --expand_size <SIZE>" option to specify which attributes
are expanded when building a kernel policy. All attributes that have
less types assigned to it than SIZE will be expanded when writing AV
rules.
With this change, some secilc options use underscore between words
(--expand_generated...) and other ones use a dash (--disable-dontaudit,
--preserve-tunables...). Moreover when there is a parameter, the current
documentation uses an equal sign and a lowercase placeholder word
(--policyvers=<version>) instead of no equal and uppercase (--expand_size <SIZE>).
How should the options appear in the manpage and the program usage in order to
have a consistent text?
You are right. I should make them "--expand-generated" and "--expand-size" for
consistently.
Jim
Cheers,
Nicolas
PS: Your patches pass the tests done by Travis-CI. The results are available at
https://travis-ci.org/fishilico/selinux/builds/221101486 .
--
James Carter <jwcart2@xxxxxxxxxxxxx>
National Security Agency
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.
