Re: [PATCH] seobject: Handle python error returns correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/30/2016 11:48 AM, Kyle Walker wrote:
> On Wed, Nov 30, 2016 at 11:05 AM, Stephen Smalley <sds@xxxxxxxxxxxxx> wrote:
>> Hmm...even after this patch, we still get the error message from
>> dbase_llist_query.  Wondering if we should drop that or if that would
>> hide anything useful for other errors.  Doesn't seem overly useful at
>> present.
> 
> It does still emit that warning, it stems from the dbase_llist_query_local
> not returning any entries and falling back to the dbase_llist_query. It is
> chatty, and not necessarily helpful. I can't really think of a use-case for
> it myself. Outside of being able to verify that a fcontext is not in the
> file_contexts.local, but in the underlying file_contexts database on
> modification.
> 
> I.E. If you see that message, you are modifying from the defaults. If you
> don't, you are modifying a fcontext that has already been modified on the
> system previously.

Yes, so I applied your patch, but I think it would make sense to drop
that message from libsemanage too.  Otherwise, users are likely to be
confused by the error message and think the change did not take effect.


_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux