Re: [PATCH v2 5/9] selinux: Create policydb version for Infiniband support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 14, 2016 at 6:56 PM, Dan Jurgens <danielj@xxxxxxxxxxxx> wrote:
> From: Daniel Jurgens <danielj@xxxxxxxxxxxx>
>
> Support for Infiniband requires the addition of two new object contexts,
> one for infiniband PKeys and another IB Ports. Added handlers to read
> and write the new ocontext types when reading or writing a binary policy
> representation.
>
> Signed-off-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> Reviewed-by: Eli Cohen <eli@xxxxxxxxxxxx>
>
> ---
> v2:
> - Shorten ib_end_port to ib_port. Paul Moore

We had a discussion about this in the last patchset and I think things
may have gotten confused.  From what I remember, according to the IB
developers the proper term is "end port"; if that is true, we probably
should use "end port", but I would prefer if we drop the underscore in
most of the places, e.g. "ib_endport" instead of "ib_end_port".

Sorry for the continuing nit pickiness.

> - Added bounds checking to port number. Paul Moore
> - Eliminated {} in OCON_PKEY case statement.  Yuval Shaia
> ---
>  security/selinux/include/security.h |    3 +-
>  security/selinux/ss/policydb.c      |  130 +++++++++++++++++++++++++++++++----
>  security/selinux/ss/policydb.h      |   27 +++++--
>  3 files changed, 136 insertions(+), 24 deletions(-)

-- 
paul moore
www.paul-moore.com
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux