On 6/30/2016 10:24 AM, Yuval Shaia wrote: > On Thu, Jun 23, 2016 at 10:52:51PM +0300, Dan Jurgens wrote: >> + if (c) { >> + if (!c->sid[0]) { >> + rc = sidtab_context_to_sid(&sidtab, >> + &c->context[0], >> + &c->sid[0]); >> + if (rc) >> + goto out; >> + } >> + *out_sid = c->sid[0]; >> + } else { >> + *out_sid = SECINITSID_PKEY; >> + } > Curly brackets are not needed > According to the coding style guide if either branch requires brackets both should use them: This does not apply if only one branch of a conditional statement is a single statement; in the latter case use braces in both branches: if (condition) { do_this(); do_that(); } else { otherwise(); } _______________________________________________ Selinux mailing list Selinux@xxxxxxxxxxxxx To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx. To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.