On Tue, Oct 27, 2015 at 6:20 PM, Stephen Smalley <sds@xxxxxxxxxxxxx> wrote:
> On 10/26/2015 05:15 PM, Andreas Gruenbacher wrote:
>> @@ -2217,7 +2231,7 @@ static int selinux_bprm_set_creds(struct
>> linux_binprm *bprm)
>>
>> old_tsec = current_security();
>> new_tsec = bprm->cred->security;
>> - isec = inode->i_security;
>> + isec = dentry_security(bprm->file->f_path.dentry);
>
> IIUC, this could change which inode label gets used when using overlayfs
> (the overlay inode or the underlying inode). Not sure whether the current
> code is correct for overlayfs (overlayfs + SELinux support still in
> progress).
Okay, let's stick with inode_security, at least for now.
>> @@ -3154,7 +3168,7 @@ out_nofree:
>> static int selinux_inode_setsecurity(struct inode *inode, const char
>> *name,
>> const void *value, size_t size, int
>> flags)
>> {
>> - struct inode_security_struct *isec = inode->i_security;
>> + struct inode_security_struct *isec = inode_security(inode);
>
> Was it intentional to not do this for selinux_inode_getsecurity() and
> selinux_inode_getsecid()?
These two hooks both pass in a const inode *, so that needs to be
changed first. Then, selinux_inode_getsecurity should obviously use
inode_security.
I'm not really sure about selinux_inode_getsecid though: can it be
call it from a non-sleeping context?
>> @@ -3241,8 +3254,8 @@ int ioctl_has_perm(const struct cred *cred, struct
>> file *file,
>> {
>> struct common_audit_data ad;
>> struct file_security_struct *fsec = file->f_security;
>> - struct inode *inode = file_inode(file);
>> - struct inode_security_struct *isec = inode->i_security;
>> + struct dentry *dentry = file->f_path.dentry;
>> + struct inode_security_struct *isec = dentry_security(dentry);
>> struct lsm_ioctlop_audit ioctl;
>> u32 ssid = cred_sid(cred);
>> int rc;
>> @@ -3263,7 +3276,7 @@ int ioctl_has_perm(const struct cred *cred, struct
>> file *file,
>> goto out;
>> }
>>
>> - if (unlikely(IS_PRIVATE(inode)))
>> + if (unlikely(IS_PRIVATE(dentry->d_inode)))
>> return 0;
>>
>> rc = avc_has_extended_perms(ssid, isec->sid, isec->sclass,
>> @@ -3506,7 +3519,7 @@ static int selinux_file_open(struct file *file,
>> const struct cred *cred)
>> struct inode_security_struct *isec;
>>
>> fsec = file->f_security;
>> - isec = file_inode(file)->i_security;
>> + isec = dentry_security(file->f_path.dentry);
>
>
> Similarly for these cases, switching from file_inode(file) to
> d_backing_inode(dentry) could affect overlayfs interaction IIUC.
Okay, let's stick with inode_security as well for now.
Thanks,
Andreas
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.
