Re: [PATCH 2/3] libsepol/cil: add ioctl whitelist support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/28/2015 02:59 PM, Steve Lawrence wrote:

...

diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c
index 6d095db..1439581 100644
--- a/libsepol/cil/src/cil_binary.c
+++ b/libsepol/cil/src/cil_binary.c

...

@@ -3162,6 +3444,9 @@ int __cil_node_to_policydb(struct cil_tree_node *node, void *extra_args)
  				}
  			}
  			break;
+		case CIL_AVRULEX:
+			rc = cil_avrulex_to_hashtable(pdb, db, node->data, args);
+			break;
  		case CIL_ROLEALLOW:
  			rc = cil_roleallow_to_policydb(pdb, db, node->data);
  			break;
@@ -3595,6 +3880,58 @@ static int role_trans_compare(hashtab_t h
  	return a->role != b->role || a->type != b->type || a->tclass != b->tclass;
  }

+/* Based on MurmurHash3, written by Austin Appleby and placed in the
+ * public domain.
+ */
+static unsigned int avrulex_hash(hashtab_t h, hashtab_key_t key)
+{

Doesn't compile without DEBUG=1 because h is unused in this function.

Also, all three patches have some whitespace issues.

Finally, some CIL test policy would be nice. You could add it to policy.cil or create a new one starting with minimum.cil.

--
James Carter <jwcart2@xxxxxxxxxxxxx>
National Security Agency
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.



[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux