On Wed, May 20, 2015 at 12:13:18PM -0400, Stephen Smalley wrote: > On 05/20/2015 12:04 PM, Dominick Grift wrote: > > On Wed, May 20, 2015 at 11:59:34AM -0400, Stephen Smalley wrote: > >> On 05/20/2015 11:51 AM, Dominick Grift wrote: > >>> On Tue, May 19, 2015 at 03:46:06PM -0400, Stephen Smalley wrote: > >> The original motivating use case for per-file labeling for sysfs was > >> libvirt labeling of specific sysfs nodes to make them accessible to > >> specific virtual machines (qemu instances). In that scenario, we needed > >> userspace to be able to drive the labeling based on more than just the > >> pathname and so genfs_contexts wasn't suitable. I do not think that is applicable anymore (although i may be wrong) > > The Android init program does a restorecon_recursive("/sys") on boot, > and specific optimizations have been introduced to prune the tree walk > when there are no relevant file_contexts entries. > > We could certainly add full genfs_context support for sysfs, even if we > do not switch to using it in Android. Some of the current /sys > file_contexts entries for Android however can't be represented in > genfs_contexts, e.g.: > /sys/devices/virtual/smdpkt/smdcntl([0-9])+/open_timeout > u:object_r:sysfs_smdcntl_open_timeout:s0 > > Also, genfs_contexts is always a prefix match, so e.g. > /sys/foo system_u:object_r:foo_t:s0 > will match /sys/foo, /sys/foobar, and /sys/foo/bar. > > In contrast, file_contexts is an anchored match, so e.g. > /sys/foo system_u:object_r:foo_t:s0 > will only match /sys/foo, > /sys/foo(/.*)? system_u:object_r:foo_t:s0 > will match /sys/foo and anything under it if it is a directory, and > /sys/foo.* will match anything beginning with /sys/foo. > > So they aren't quite the same. > That sounds troublesome. Then again, just because one implements genfscon support that does not mean that labeling based on file_contexts can't be used for stuff that cannot be tackled with genfscon. Right? -- 02DFF788 4D30 903A 1CF3 B756 FB48 1514 3148 83A2 02DF F788 http://keys.gnupg.net/pks/lookup?op=vindex&search=0x314883A202DFF788 Dominick Grift
Attachment:
pgpQhBXBQOGEY.pgp
Description: PGP signature
_______________________________________________ Selinux mailing list Selinux@xxxxxxxxxxxxx To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx. To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.