Re: [PATCH] selinux: Print 'sclass' as string when unrecognized netlink message occurs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, April 07, 2015 07:28:07 AM Paul Moore wrote:
> On Thu, Apr 2, 2015 at 11:58 AM, Marek Milkovic <mmilkovi@xxxxxxxxxx> wrote:
> > This prints the 'sclass' field as string instead of index in unrecognized
> > netlink message. The textual representation makes it easier to
> > distinguish the right class.
> > 
> > Signed-off-by: Marek Milkovic <mmilkovi@xxxxxxxxxx>
> > ---
> > 
> >  security/selinux/hooks.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Thanks Marek, this looks good.  I'm adding this to the next queue for
> after the merge window.

Merged into next with a minor reformat to fit the code into an 80-char wide 
terminal.

> > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> > index 87a9156..d75f525 100644
> > --- a/security/selinux/hooks.c
> > +++ b/security/selinux/hooks.c
> > @@ -4712,8 +4712,8 @@ static int selinux_nlmsg_perm(struct sock *sk,
> > struct sk_buff *skb)> 
> >                 if (err == -EINVAL) {
> >                 
> >                         printk(KERN_WARNING
> >                         
> >                                "SELinux: unrecognized netlink message:"
> > 
> > -                              " protocol=%hu nlmsg_type=%hu
> > sclass=%hu\n",
> > -                              sk->sk_protocol, nlh->nlmsg_type,
> > sksec->sclass); +                              " protocol=%hu
> > nlmsg_type=%hu sclass=%s\n", +                             
> > sk->sk_protocol, nlh->nlmsg_type, secclass_map[sksec->sclass - 1].name);> 
> >                         if (!selinux_enforcing ||
> >                         security_get_allow_unknown())
> >                         
> >                                 err = 0;
> >                 
> >                 }
> > 
> > --
> > 2.1.0
> > 
> > _______________________________________________
> > Selinux mailing list
> > Selinux@xxxxxxxxxxxxx
> > To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
> > To get help, send an email containing "help" to
> > Selinux-request@xxxxxxxxxxxxx.

-- 
paul moore
www.paul-moore.com

_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux