Re: [PATCH] libsemanage: fix fname[] initialization in test_utilities.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/16/2015 06:33 AM, Petr Lautrbach wrote:
> There's no guaranty that last item in "char fname[]" will be a null character.
> Fixes segfault on some systems:
> 
>   Test: semanage_nc_sort ...passedtest_semanage_findval: : Invalid argument
> libsemanage-tests: TestRun.c:160: CU_assertImplementation: Assertion `((void *)0) != f_pCurTest' failed.
> make[1]: *** [test] Aborted (core dumped)
> 
> Signed-off-by: Petr Lautrbach <plautrba@xxxxxxxxxx>
> ---
>  libsemanage/tests/test_utilities.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libsemanage/tests/test_utilities.c b/libsemanage/tests/test_utilities.c
> index 4d25b07..32cc33c 100644
> --- a/libsemanage/tests/test_utilities.c
> +++ b/libsemanage/tests/test_utilities.c
> @@ -45,7 +45,7 @@ void test_slurp_file_filter(void);
>  
>  char fname[] = {
>  	'T', 'E', 'S', 'T', '_', 'T', 'E', 'M', 'P', '_', 'X', 'X', 'X', 'X',
> -	'X', 'X'
> +	'X', 'X', '\0'
>  };
>  int fd;
>  FILE *fptr;
> 

Thanks, applied.

_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.




[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux