On Thursday, June 19, 2014 08:58:31 AM Namhyung Kim wrote: > Hi Paul, > > On Thu, Jun 19, 2014 at 4:36 AM, Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > > > @@ -402,19 +402,14 @@ static int cond_read_node(struct policydb *p, > > > struct > >> > >> cond_node *node, void *fp) int rc; > >> > >> struct cond_expr *expr = NULL, *last = NULL; > >> > >> - rc = next_entry(buf, fp, sizeof(u32)); > >> + rc = next_entry(buf, fp, sizeof(buf)); > > > > This is a bit nit-picky, but how about using "sizeof(u32) * 2"? It is > > more > > consistent with the rest of the function and helps underscore that we are > > reading two 32-bit values. > > > > Assuming you're okay with the change I can fix it up when I apply the > > patch. > > I'm okay with it. :) Great, both patches are applied. -- paul moore www.paul-moore.com _______________________________________________ Selinux mailing list Selinux@xxxxxxxxxxxxx To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx. To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.
