2014-06-10 3:22 GMT+02:00 Christopher J. PeBenito <cpebenito@xxxxxxxxxx>:
> On 5/28/2014 1:04 PM, Sven Vermeulen wrote:
>> Index: secmds/replcon.cc
>> ===================================================================
>> --- secmds/replcon.cc (revision 4973)
>> +++ secmds/replcon.cc (working copy)
>> @@ -60,7 +60,7 @@
>> {NULL, 0, NULL, 0}
>> };
>>
>> -extern int lsetfilecon_raw(const char *, security_context_t) __attribute__ ((weak));
>> +extern int lsetfilecon_raw(const char *, const char *) __attribute__ ((weak));
>
> Unfortunately, this breaks it in the same way if you compile with libselinux < 2.3 with this patch. The preference would be a patch that allows it to compile with any recent libselinux, rather than requiring libselinux 2.3.
When compiling SETools on ArchLinux I got this error message from gcc
(version 4.9.0):
replcon.cc:73:25: error: invalid operands of types '<unresolved
overloaded function type>' and 'long int' to binary 'operator!='
if (lsetfilecon_raw != NULL)
I've never used weak functions in C libraries so I don't know the
proper fix to support libselinux versions which don't provide
lsetfilecon_raw, but as in ArchLinux only the most recent stable
version of packages is supported, I simply removed all the code
related to the "weak function trick" to make it works [1]. According
to git log, lsetfilecon_raw existed in 2008 [2]. Is it possible to
replace replcon_lsetfilecon with lsetfilecon_raw in SETools or are
there still supported versions of libselinux without lsetfilecon_raw?
By the way, while speaking about patches, a few days ago I wrote an
amazing bugfix for libsemanage [3]. Where should I send this patch? As
selinux@xxxxxxxxxxxxx has been silent about my latest patch [4] I'm
wondering whether it is the right ML to send patches to.
Nicolas
[1] https://github.com/archlinuxhardened/selinux/blob/master/setools/0001-fix-compile-error.patch
[2] https://github.com/fishilico/selinux/blob/13cd4c8960688af11ad23b4c946149015c80d549/libselinux/src/lsetfilecon.c
[3] https://github.com/fishilico/selinux/commit/b9688372828d8f2609afb68160b100bdffd9ead0
[4] http://marc.info/?l=selinux&m=140086882622086&w=2
_______________________________________________
Selinux mailing list
Selinux@xxxxxxxxxxxxx
To unsubscribe, send email to Selinux-leave@xxxxxxxxxxxxx.
To get help, send an email containing "help" to Selinux-request@xxxxxxxxxxxxx.
