Hi! On Mon, 2012-12-03 at 12:15:23 -0500, Eric Paris wrote: > On Tue, Nov 20, 2012 at 10:27 AM, Guillem Jover <guillem@xxxxxxxxxx> wrote: > > Some context for the rpm folks. While looking into improving SELinux > > support in dpkg, I noticed that dpkg is not setting a new execution > > context when running the package maintainer scripts (package scriptlets > > in rpm lingo, I think). And when checking how to implement it, it seemed > > that reusing something like the current rpm_execcon() would be best, > > and Stephen seemed to agree. For more details, see the thread starting > > at <http://marc.info/?t=135236358700001&r=1&w=2>. > > > > Having checked the rpm code, and the mailing list, it seems like this > > new function would make it easy to be used there too for stuff like > > the Lua scriptlets (if desired), and might make it easier also to > > switch to the new rpm plugins framework (?). > > > > I've discarded the verified argument for the new function because that > > seemed best handled from the rpm side, and in any case seemed unrelated > > to the execution context. I'm not entirely convinced about the function > > name though, as it could be confused as applying a context to a path on > > the filesystem. And I've not marked rpm_execcon() as deprecated because > > it might be annoying at the beginning, but would change that if you think > > it makes sense. > > > > In any case, here's a patch adding such new function. For dpkg, given > > that it has never set a new context up to now, I'd only make use of the > > function if it's available in libselinux, as I don't think it's worth it > > to ship an embedded copy. For rpm, I guess it could switch to use the > > function also if available and fallback to rpm_execcon() otherwise. After > > a while the rpm_execcon() function could be removed from libselinux, on > > the next ABI break, as I understand was the plan anyway (?). > > > > (The patch might not apply w/o the man page cleanup series.) > > > > So, what do you think? > Anyone have any comments? I don't see a problem if such a function > would make your life better... Any further thoughts on this? rpm and dpkg now carry an almost identical implementation of the proposed function: <http://rpm.org/gitweb?p=rpm.git;a=blob;f=plugins/selinux.c;hb=HEAD#l90> <http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=blob;f=src/script.c;hb=HEAD#l146> Thanks, Guillem -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
