-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This patch looks good to me. acked. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlD+pvcACgkQrlYvE4MpobN25wCg2qVoFl5USiGb7ZwHYAoDKbx0 F8EAniCrGrRLBve0fPlOjLtQrTnCeZB4 =ohFc -----END PGP SIGNATURE-----
>From b01cd232d720086a48e9b30b10c88bd78752d973 Mon Sep 17 00:00:00 2001 From: rhatdan <dwalsh@xxxxxxxxxx> Date: Tue, 16 Oct 2012 10:06:38 -0400 Subject: [PATCH 43/84] policycoreutils: gui: Start using Popen, instead of os.spawnl Signed-off-by: Eric Paris <eparis@xxxxxxxxxx> --- policycoreutils/gui/modulesPage.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/policycoreutils/gui/modulesPage.py b/policycoreutils/gui/modulesPage.py index ee40fd3..9ff0766 100644 --- a/policycoreutils/gui/modulesPage.py +++ b/policycoreutils/gui/modulesPage.py @@ -26,6 +26,7 @@ import sys import seobject import selinux from semanagePage import *; +from subprocess import Popen, PIPE ## ## I18N @@ -88,7 +89,7 @@ class modulesPage(semanagePage): self.filter=filter self.store.clear() try: - fd=os.popen("semodule -l") + fd = Popen("semodule -l", shell=True, stdout=PIPE).stdout l = fd.readlines() fd.close() for i in l: @@ -105,7 +106,7 @@ class modulesPage(semanagePage): def new_module(self, args): try: - os.spawnl(os.P_NOWAIT, "/usr/share/system-config-selinux/polgengui.py") + Popen(["/usr/share/system-config-selinux/polgengui.py"]) except ValueError, e: self.error(e.args[0]) -- 1.8.1