On Fri, 2012-07-27 at 11:58 -0700, William Roberts wrote: > This patch will allow non-matched apps in seapp_contexts to > still be spawned via the zygote. An error message will be sent > to logcat. > > Change-Id: I9fb5dcfeb384a26e6a01d69bffd2ef14af74c51c > Signed-off-by: William Roberts <w.roberts@xxxxxxxxxxxxxxx> > --- > src/android.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/android.c b/src/android.c > index ef27991..50666a0 100644 > --- a/src/android.c > +++ b/src/android.c > @@ -526,8 +526,7 @@ int selinux_android_setcontext(uid_t uid, > selinux_log(SELINUX_ERROR, > "%s: No match for app with uid %d, seinfo %s, name %s\n", > __FUNCTION__, uid, seinfo, pkgname); > - rc = -1; > - goto out; > + goto err; This leads to a double free. That's the other reason for not going to err here. > } > > ctx_str = context_str(ctx); > @@ -559,7 +558,7 @@ err: > "%s: Error setting context for app with uid %d, seinfo %s: %s\n", > __FUNCTION__, uid, seinfo, strerror(errno)); > > - rc = -1; > + rc = (security_getenforce() == 0) ? 0 : -1; > goto out; > oom: > selinux_log(SELINUX_ERROR, "%s: Out of memory\n", __FUNCTION__); -- Stephen Smalley National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
