-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This patch looks good to me. acked. White space needs to be at least consistent. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7vqz4ACgkQrlYvE4MpobNLVQCg5AF6+Ga9U3cxug+9qsFBgOoR S7MAoMW/yDrUr/5MLqJ10wbBcqpBIIWX =slIZ -----END PGP SIGNATURE-----
>From be09a6674d8481333a742c00a6885e0a0a01bd35 Mon Sep 17 00:00:00 2001 From: Eric Paris <eparis@xxxxxxxxxx> Date: Wed, 3 Aug 2011 12:00:30 -0400 Subject: [PATCH 08/25] policycoreutils: semanage: FIXME whitespace changes in seobject Just whitespace and indention changes. No real code. I'm not certain they are all a good idea. NOT-Signed-off-by: Eric Paris <eparis@xxxxxxxxxx> Acked-by: Dan Walsh <dwalsh@xxxxxxxxxx> --- policycoreutils/semanage/seobject.py | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/policycoreutils/semanage/seobject.py b/policycoreutils/semanage/seobject.py index 8cfbad3..b8f978d 100644 --- a/policycoreutils/semanage/seobject.py +++ b/policycoreutils/semanage/seobject.py @@ -165,6 +165,7 @@ class semanageRecords: transaction = False handle = None store = None + def __init__(self, store): global handle @@ -332,6 +333,7 @@ class permissiveRecords(semanageRecords): name = semanage_module_get_name(mod) if name and name.startswith("permissive_"): l.append(name.split("permissive_")[1]) + return l def list(self, heading = 1, locallist = 0): @@ -883,6 +885,7 @@ class portRecords(semanageRecords): return ( k, proto_d, low, high ) def __add(self, port, proto, serange, type): + if is_mls_enabled == 1: if serange == "": serange = "s0" @@ -945,6 +948,7 @@ class portRecords(semanageRecords): self.commit() def __modify(self, port, proto, serange, setype): + if serange == "" and setype == "": if is_mls_enabled == 1: raise ValueError(_("Requires setype or serange")) @@ -1175,7 +1179,6 @@ class nodeRecords(semanageRecords): if rc < 0: raise ValueError(_("Could not set mask for %s") % addr) - rc = semanage_context_set_user(self.sh, con, "system_u") if rc < 0: raise ValueError(_("Could not set user in addr context for %s") % addr) @@ -1232,7 +1235,6 @@ class nodeRecords(semanageRecords): raise ValueError(_("Could not query addr %s") % addr) con = semanage_node_get_con(node) - if serange != "": semanage_context_set_mls(self.sh, con, untranslate(serange)) if setype != "": -- 1.7.8