On Wed, Aug 17, 2011 at 11:34 AM, Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote: > On 8/17/2011 6:35 AM, Eric Paris wrote: >> >> On Wed, Aug 17, 2011 at 1:09 AM, Casey Schaufler<casey@xxxxxxxxxxxxxxxx> >> wrote: >>> >>> Is there some reason that linux/selinux.h is >>> #included in linux/cred.h? >>> >>> I've been building kernels with the inclusion >>> commented out and I have encountered no problems. >>> >>> It's not a problem, but I am curious. >> >> It can be safely moved, but not removed. This was added when >> creds_are_invalid() was implemented in the header, which makes SELinux >> specific calls (see commit ed868a56988464cd31de0302426a5e94d3127f10). >> This function was moved to kernel/cred.c in commit >> 74908a0009eb36054190ab80deb9671014efed96 but the header was not moved >> with it. If you want to send a patch to move the header from cred.h >> to cred.c I think that would make a lot of sense. > > Enlightenment. Thank you. > > Since creds_are_invalid() only exists under CONFIG_DEBUG_CREDENTIALS > I would expect the include of selinux.h to be under that ifdef as well. Seems quite reasonable to me... -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
