Re: [PATCH 8/9] LSM: Pass linux_binprm pointer to open_exec() so creds are available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote:

> 819         struct linux_binprm bprm;
> 
> Here bprm is allocated from stack memory without initialization
> whereas bprm in do_execve() is allocated using kzalloc().

That's true; most of it doesn't need initialisation, but some bits of it do -
but aren't initialised here.  Not only that, it's quite a large struct, so
probably shouldn't be on the stack anyway - especially in NOMMU mode.

Anyway, I've posted a patch independent of this patch series to fix this.

David

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.


[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux