On Thu, Feb 24, 2011 at 09:51:04AM -0500, Eric Paris wrote: > All printk() statement require a KERN_*. I've often heard upstream > people say that every printk should only be printed if you expect the > user to do something with it. If it doesn't give the user enough > information to fix whatever the problem is, or know how to fix > whatever the problem is, it's a bad printk. I don't know this code at > all, but I'm pretty sure if I got those printk's I'd just feel > dumb.... > The problem with this patch is, that it was one of my debugging patches when I tried to find out why my packets are dropped. It was not contemplated to push it upstream when I wrote it. Then I thought it would be good to print out a message if these packets are dropped and I picked the patch from my debugging branch, which was a bad idea. I think we should drop this patch entirely and focus on the remaining 3 paches for now, as they are real fixes. So I could resend the remaining patches for another round of review, or does anybody want to thake them as they are? Steffen -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
