Re: [PATCH 09/10] selinux: xfrm - notify users on dropped packets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 16 Feb 2011, Paul Moore wrote:

> >  	if (!xp->security)
> > -		if (x->security)
> > -			/* unlabeled policy and labeled SA can't match */
> > +		if (x->security) {
> > +			if (net_ratelimit())
> > +				printk("selinux: unlabeled policy and labeled"
> > +				       "SA can't match!\n");

I don't think these paths have been tested.  Think how the above will look 
when printed.  Same for the rest in the patch.

Please get rid of the exclamation marks.


- James
-- 
James Morris
<jmorris@xxxxxxxxx>

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.


[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux