Re: [patch 7/7 v2] selinux: fix error codes in symtab_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2010-06-12 at 20:57 +0200, Dan Carpenter wrote:
> hashtab_create() only returns NULL on allocation failures to -ENOMEM is
> appropriate here.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> Acked-by: Eric Paris <eparis@xxxxxxxxxx>

Acked-by:  Stephen D. Smalley <sds@xxxxxxxxxxxxx>
for the entire series.

> ---
> V2: unchanged.
> 
> diff --git a/security/selinux/ss/symtab.c b/security/selinux/ss/symtab.c
> index bcf9f62..160326e 100644
> --- a/security/selinux/ss/symtab.c
> +++ b/security/selinux/ss/symtab.c
> @@ -36,7 +36,7 @@ int symtab_init(struct symtab *s, unsigned int size)
>  {
>  	s->table = hashtab_create(symhash, symcmp, size);
>  	if (!s->table)
> -		return -1;
> +		return -ENOMEM;
>  	s->nprim = 0;
>  	return 0;
>  }
> 
> 
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
> the words "unsubscribe selinux" without quotes as the message.

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.


[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux