On Tue, 2009-07-07 at 22:48 +1000, James Morris wrote: > On Tue, 7 Jul 2009, Stephen Smalley wrote: > > > 1) Create one patch that only renames security_ functions within > > selinux to sel_ or selinux_ (I don't care which; Paul seemed to prefer > > sel_ - James or Eric?). That should be non-controversial and easy to > > merge. > > sel_ gets the point across :-) Obviously I preferred selinux_ since I'm the one who ask him to do it. Anyway, I guess James and Paul both like sel_ and I'm not going to argue loud enough to matter... I also don't care about the 80 character limit and told him not to worry too much about it. I know it's a coding style rule, and I know long lines are problematic, but if any one of us who actually maintains this code can't handle 81 characters I'll buy you a wonderful mid 90's monitor and video card. Don't program on an OLPC. If it fits on my 12" ultra portable, I'm happy with the code. I do accept there need to be reasonable limits, I jotted down that cond_read_av_list and read_f both were too long to live.... Thomas, I'd suggest just doing the minimum that sds suggested. -Eric -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
