Re: [PATCH] SElinux: Fix some typos.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



James Morris wrote:
On Thu, 2 Jul 2009, Justin P. Mattock wrote:

No I will not be afraid of submitting patches, and having them be rejected.
all part of the learning curve.

I'd suggest generally not starting out with spelling, grammatical and
formatting patches.  It eats reviewer bandwidth, perturbs the codebase
(causing people working on it to have to update their code) and does not
give you as much opportunity to to learn about the code.

No my intentions were not to eat reviewer bandwidth, or get in the way.
just turned out as I was going through(for example) hooks.c I noticed a portion of it
had proper grammar, and then a portion of it seemed as if the author was too
much in a hurry to worry about that.(so I figured hey why not, that's all).
Try fixing smaller, known bugs or adding small useful changes.

The TODO list for the SELinux kernel code is here:
http://selinuxproject.org/page/Kernel_Development

Thanks for this, Ill have to give this a look and see.

You can also email the maintainers and ask for suggestions on what to
tackle.


- James
alright James,
Thanks for taking the time
next time I decide to have a major case of
OCD, I'll remember that creating churn is not
a good idea.

Justin P. Mattock

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.

[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux