Re: [PATCH] SELinux: hold tasklist_lock and siglock while waking wait_chldexit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 4 Nov 2008, Eric Paris wrote:

> From: Eric Paris <eparis@xxxxxxxxxx>
> 
> SELinux has long been calling wake_up_interruptible() on
> current->parent->signal->wait_chldexit without holding any locks.  It
> appears that this operation should hold the tasklist_lock to dereference
> current->parent and we should hold the siglock when waking up the
> signal->wait_chldexit.
> 
> Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>

This seems correct to me, too, although I'll just push it to 
security-testing#next at least for the moment so it gets some testing.

How did you find this issue?


-- 
James Morris
<jmorris@xxxxxxxxx>

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.

[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux