On Friday 05 September 2008 4:51:46 am James Morris wrote: > On Tue, 2 Sep 2008, Paul Moore wrote: > > It turns out that checking to see if skb->sk is NULL is not a very > > good indicator of a forwarded packet as some locally generated > > packets also have skb->sk set to NULL. Fix this by not only > > checking the skb->sk field but also the IP[6]CB(skb)->flags field > > for the IP[6]SKB_FORWARDED flag. > > > > Signed-off-by: Paul Moore <paul.moore@xxxxxx> > > --- > > > > security/selinux/hooks.c | 36 > > +++++++++++++++++++++++++++--------- 1 files changed, 27 > > insertions(+), 9 deletions(-) > > Acked-by: James Morris <jmorris@xxxxxxxxx> Thanks for taking the time to review the patches and send feedback, I know they weren't small. I've made all the corrections you've suggested as well as the ones that Andrew and Randy pointed out. I'm building a new kernel to test right now, if all goes well I'll push the new bits tonight or tomorrow. I've also added all your ACKs to their respective patches except for this one because I made some non-trivial changes and didn't think it was fair to use your ACK. While I was looking at the code I realized that we are calling selinux_parse_skb() in the per-packet processing functions a bit too early (my fault) resulting in potentially wasted cycles. I've fixed it in this patch and you'll see the change shortly ... -- paul moore linux @ hp -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
