On Wednesday 06 August 2008 8:18:20 pm Vesa-Matti Kari wrote: > Replace "thing != NULL" comparisons with just "thing" to make > the code look more uniform (mixed styles were used even in the > same source file). > > Signed-off-by: Vesa-Matti Kari <vmkari@xxxxxxxxxxxxxx> > --- > security/selinux/ss/avtab.c | 2 +- > security/selinux/ss/conditional.c | 16 ++++++++-------- > security/selinux/ss/ebitmap.c | 4 ++-- > security/selinux/ss/hashtab.c | 6 +++--- > security/selinux/ss/services.c | 8 ++++---- > security/selinux/ss/sidtab.c | 12 ++++++------ In my opinion this suffers from the same problems as the variable renaming patches. I vote "no". -- paul moore linux @ hp -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.