Re: [patch] libsepol write.c has shadowed var

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2008-06-13 at 11:43 -0400, Joshua Brindle wrote:
> This patch addresses a shadowed var that prevents libsepol from being built with DEBUG=1
> 
> Signed-off-by: Joshua Brindle <method@xxxxxxxxxxxxxxx>
> 
> ---
> 
> Index: libsepol/src/write.c
> ===================================================================
> --- libsepol/src/write.c	(revision 2908)
> +++ libsepol/src/write.c	(working copy)
> @@ -1625,10 +1625,10 @@
>  	if (p->policyvers < POLICYDB_VERSION_PERMISSIVE &&
>  	    p->policy_type == POLICY_KERN) {
>  		ebitmap_node_t *tnode;
> -		unsigned int i;
> +		unsigned int j;
>  
> -		ebitmap_for_each_bit(&p->permissive_map, tnode, i) {
> -			if (ebitmap_node_get_bit(tnode, i)) {
> +		ebitmap_for_each_bit(&p->permissive_map, tnode, j) {
> +			if (ebitmap_node_get_bit(tnode, j)) {
>  				WARN(fp->handle, "Warning! Policy version %d cannot "
>  				     "support permissive types, but some were defined",
>  				     p->policyvers);

Any particular reason we can't just use the local var from the outer
scope?

-- 
Stephen Smalley
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.

[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux