On Thu, 28 Feb 2008, Paul Moore wrote: > While looking at the SELinux secid/secctx conversion functions I realized they > could probably do with a little cleanup to reduce the amount of code and make > better use of existing string processing functions in the kernel. Making use > of the kernel's existing string processing functions is a good idea as many > architectures have specialized/optimized routines which should be an > improvement over the generic code in the SELinux security server. Please always include a signed-off-by line, in case the patch gets applied. > -static int context_struct_to_string(struct context *context, char **scontext, u32 *scontext_len) > +static int context_struct_to_string(struct context *context, > + char **scontext, u32 *scontext_len) I tend to not prefer the 80-column rule for function declarations, as it makes the code harder to grep (not a show-stopper, but generally, don't try and fix these). - James -- James Morris <jmorris@xxxxxxxxx> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.
